From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Tue, 14 Jul 2009 12:38:18 GMT
Subject: Re: [PATCH] t4202-log.sh: Test git log --no-walk sort order
Message-ID: <4A5C7C3A.9080506@drmicha.warpmail.net>
In-Reply-To: <4A5C785C.6060706@viscovery.net>

Johannes Sixt venit, vidit, dixit 14.07.2009 14:21:
> Michael J Gruber schrieb:
>> +test_expect_success 'git log --no-walk <commits> sorts by commit time' '
> ...
>> +test_expect_success 'git show <commits> does not sort by commit time' '
> 
> Thanks, but sorry that I'm nit-picking here:

This not being my first patch, I don't expect any patch to go through
without nit-picking here - which, in most cases, is really a good thing ;)

> You say what git show does
> not do, but shouldn't you say what git show should do?
> 
> 	'git show shows commits in command line order'

Well, I assumed "does not sort" == "leaves as is". But, even if it is,
still "does not sort by commit time" != "leaves as is". v2 upcoming...

Michael