Re: [PATCHv2] t4202-log.sh: Test git log --no-walk sort order

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jul 14, 2009, 14:28 UTC
Message-ID: <4A5C9624.1020404@drmicha.warpmail.net>
In-Reply-To: <alpine.DEB.1.00.0907141612350.4553@intel-tinevez-2-302>

Johannes Schindelin venit, vidit, dixit 14.07.2009 16:13:

Show 28 quoted lines

> Hi,
> 
> On Tue, 14 Jul 2009, Michael J Gruber wrote:
> 
>> 'git log --no-walk' sorts commits by commit time whereas 'git show' does
>> not (it leaves them as given on the command line). Document this by two
>> tests so that we never forget why ba1d450 (Tentative built-in "git
>> show", 2006-04-15) introduced it and 8e64006 (Teach revision machinery
>> about --no-walk, 2007-07-24) exposed it as an option argument.
> 
> Thanks.
> 
>> +cat > expect << EOF
>> +5d31159 fourth
>> +ein
>> +804a787 sixth
>> +a/two
>> +394ef78 fifth
>> +a/two
>> +EOF
>> +test_expect_success 'git show <commits> leaves list of commits as given' '
>> +	git show --oneline --name-only 5d31159 804a787 394ef78 > actual &&
>> +	test_cmp expect actual
>> +'
> 
> Just to hazard a guess: you probably used --name-only to avoid having the 
> whole diff in the output, right?  In that case, you might want to use -s 
> in the future (I do not think this needs fixing in this patch).

Yes, exactly. I was looking for "--no-p". And I was looking really hard! I didn't see this in git-log.1 nor git-show.1 nor git-diff.1. Now, looking again, I find it in git-diff-tree.1. Grrmml. With hindsight, it's clear that all diff-tree options apply.

It seems that more of git-diff-tree.txt should show up in the man pages for diff, log and show (i.e. be in diff-*.txt) or at least be referenced. What do you think?

Michael