git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2] t4202-log.sh: Test git log --no-walk sort order

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Jul 14, 2009, 12:45 UTC
Message-ID
<1247575519-9629-1-git-send-email-git@drmicha.warpmail.net>
In-Reply-To
<4A5C785C.6060706@viscovery.net>

'git log --no-walk' sorts commits by commit time whereas 'git show' does not (it leaves them as given on the command line). Document this by two tests so that we never forget why ba1d450 (Tentative built-in "git show", 2006-04-15) introduced it and 8e64006 (Teach revision machinery about --no-walk, 2007-07-24) exposed it as an option argument.

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
v2: Make it clearer (in the commmit message and the test description) that git
show leaves the commits as specified.
Nit-picked-by: Johannes Sixt <j.sixt@viscovery.net>
...but he was right!
 t/t4202-log.sh |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index aad3894..72ba42c 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-log.sh
@@ -149,6 +149,29 @@ test_expect_success 'git log --follow' '
 
 '
 
+cat > expect << EOF
+804a787 sixth
+394ef78 fifth
+5d31159 fourth
+EOF
+test_expect_success 'git log --no-walk <commits> sorts by commit time' '
+	git log --no-walk --oneline 5d31159 804a787 394ef78 > actual &&
+	test_cmp expect actual
+'
+
+cat > expect << EOF
+5d31159 fourth
+ein
+804a787 sixth
+a/two
+394ef78 fifth
+a/two
+EOF
+test_expect_success 'git show <commits> leaves list of commits as given' '
+	git show --oneline --name-only 5d31159 804a787 394ef78 > actual &&
+	test_cmp expect actual
+'
+
 test_expect_success 'setup case sensitivity tests' '
 	echo case >one &&
 	test_tick &&
-- 
1.6.3.3.483.g4f5e
Previous: Michael J GruberNext: Johannes Schindelin
Message 12 of 17 in “Make 'git show' more useful”
  1. Linus TorvaldsJul 13, 2009
  2. Junio C HamanoJul 13, 2009
  3. Re: Make 'git show' more usefulPaolo Bonzini, Jul 13, 2009
  4. Linus TorvaldsJul 14, 2009
  5. Johannes SchindelinJul 14, 2009
  6. Linus TorvaldsJul 14, 2009
  7. Paolo BonziniJul 14, 2009
  8. Johannes SchindelinJul 14, 2009
  9. t4202-log.sh: Test git log --no-walk sort orderMichael J Gruber, Jul 14, 2009
  10. Johannes SixtJul 14, 2009
  11. Michael J GruberJul 14, 2009
  12. [PATCHv2] t4202-log.sh: Test git log --no-walk sort orderMichael J Gruber, Jul 14, 2009
  13. Johannes SchindelinJul 14, 2009
  14. Michael J GruberJul 14, 2009
  15. t4202-log.sh: Test git log --no-walk sort orderMichael J Gruber, Jul 17, 2009
  16. Johannes SchindelinJul 17, 2009
  17. Johannes SchindelinJul 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.