git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/8] archive: use index instead of parsing tree directly

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Apr 8, 2009, 21:02 UTC
Message-ID
<49DD10EB.3090706@lsrfire.ath.cx>
In-Reply-To
<1239185133-4181-7-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy schrieb:
Show 11 quoted lines
> Currently:
> 
>  - "git archive" parses trees directly
>  - attr mechanism does not support in-tree attributes
> 
> Making attr.c support in-tree attributes is quite a non-trivial task,
> IMHO. Instead this patch makes "git archive" read tree to index first,
> then start exporting from there.
> 
> One minor regression: "git archive" now will no longer generate
> directory entries, only files.

I don't like the need to prepare an index of all paths up front, but that's just a gut feeling. I haven't looked into implementing in-tree attribute support in attr.c; is it really that hard? Other commands would benefit from this, too, right (e.g. any command using attributes in a bare repo)?

René
Previous: René ScharfeNext: René Scharfe
Message 14 of 24 in “support "in-tree attributes" for git-archive”
  1. 0/8 support "in-tree attributes" for git-archiveNguyễn Thái Ngọc Duy, Apr 8, 2009
  2. 1/8 archive: add shortcuts for --format and --prefixNguyễn Thái Ngọc Duy, Apr 8, 2009
  3. 2/8 move prune_cache() to git libNguyễn Thái Ngọc Duy, Apr 8, 2009
  4. 3/8 archive: add a failure test wrt .gitattributes misreadingNguyễn Thái Ngọc Duy, Apr 8, 2009
  5. 4/8 archive: add tests for directory selectionNguyễn Thái Ngọc Duy, Apr 8, 2009
  6. 5/8 attr: add GIT_ATTR_INDEX "direction"Nguyễn Thái Ngọc Duy, Apr 8, 2009
  7. 6/8 archive: use index instead of parsing tree directlyNguyễn Thái Ngọc Duy, Apr 8, 2009
  8. 7/8 archive: disregard .gitattributes on working directoryNguyễn Thái Ngọc Duy, Apr 8, 2009
  9. 8/8 archive: support creating archives from indexNguyễn Thái Ngọc Duy, Apr 8, 2009
  10. René ScharfeApr 8, 2009
  11. Junio C HamanoApr 8, 2009
  12. Junio C HamanoApr 8, 2009
  13. René ScharfeApr 8, 2009
  14. René ScharfeApr 8, 2009
  15. René ScharfeApr 8, 2009
  16. Junio C HamanoApr 8, 2009
  17. René ScharfeApr 13, 2009
  18. Nguyen Thai Ngoc DuyApr 14, 2009
  19. René ScharfeApr 14, 2009
  20. Junio C HamanoApr 16, 2009
  21. René ScharfeApr 17, 2009
  22. Junio C HamanoApr 18, 2009
  23. Junio C HamanoApr 8, 2009
  24. René ScharfeApr 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.