From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Wed, 08 Apr 2009 21:02:35 GMT
Subject: Re: [PATCH 6/8] archive: use index instead of parsing tree directly
Message-ID: <49DD10EB.3090706@lsrfire.ath.cx>
In-Reply-To: <1239185133-4181-7-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy schrieb:
> Currently:
> 
>  - "git archive" parses trees directly
>  - attr mechanism does not support in-tree attributes
> 
> Making attr.c support in-tree attributes is quite a non-trivial task,
> IMHO. Instead this patch makes "git archive" read tree to index first,
> then start exporting from there.
> 
> One minor regression: "git archive" now will no longer generate
> directory entries, only files.

I don't like the need to prepare an index of all paths up front, but
that's just a gut feeling.  I haven't looked into implementing in-tree
attribute support in attr.c; is it really that hard?  Other commands
would benefit from this, too, right (e.g. any command using attributes
in a bare repo)?

René