git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/8] archive: add a failure test wrt .gitattributes misreading

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Apr 14, 2009, 20:12 UTC
Message-ID
<49E4EE49.6030404@lsrfire.ath.cx>
In-Reply-To
<fcaeb9bf0904132341s777ca697p1930df10eb1ff37b@mail.gmail.com>
Nguyen Thai Ngoc Duy schrieb:
Show 13 quoted lines
> 2009/4/13 René Scharfe <rene.scharfe@lsrfire.ath.cx>:
>> Also, the last sentence of the description may be taken to imply a
>> mixing of attributes from work tree and exported tree is done, which is
>> not the case with the patch from series 2 (and shouldn't be).  Perhaps:
>> "With this option, .gitattributes files are read from the work tree
>> instead of from the exported tree."
> 
> I'm at work and haven't had chance to read other mails carefully. Wrt
> to the description, it reads from index too if it fails to read from
> worktree. So perhaps "With this option, .gitattributes files are read
> from work tree (or from index if they are missing from work tree)
> instead of from exported tree.", unless you want to introduce another
> "attr direction" to read from work tree only.

Err, yes, that was nonsense, please disregard this part. Sorry. I somehow mixed up falling back to the index and merging the contents of attribute files from both sources, not sure why. :-/

René
Previous: Nguyen Thai Ngoc DuyNext: Junio C Hamano
Message 19 of 24 in “support "in-tree attributes" for git-archive”
  1. 0/8 support "in-tree attributes" for git-archiveNguyễn Thái Ngọc Duy, Apr 8, 2009
  2. 1/8 archive: add shortcuts for --format and --prefixNguyễn Thái Ngọc Duy, Apr 8, 2009
  3. 2/8 move prune_cache() to git libNguyễn Thái Ngọc Duy, Apr 8, 2009
  4. 3/8 archive: add a failure test wrt .gitattributes misreadingNguyễn Thái Ngọc Duy, Apr 8, 2009
  5. 4/8 archive: add tests for directory selectionNguyễn Thái Ngọc Duy, Apr 8, 2009
  6. 5/8 attr: add GIT_ATTR_INDEX "direction"Nguyễn Thái Ngọc Duy, Apr 8, 2009
  7. 6/8 archive: use index instead of parsing tree directlyNguyễn Thái Ngọc Duy, Apr 8, 2009
  8. 7/8 archive: disregard .gitattributes on working directoryNguyễn Thái Ngọc Duy, Apr 8, 2009
  9. 8/8 archive: support creating archives from indexNguyễn Thái Ngọc Duy, Apr 8, 2009
  10. René ScharfeApr 8, 2009
  11. Junio C HamanoApr 8, 2009
  12. Junio C HamanoApr 8, 2009
  13. René ScharfeApr 8, 2009
  14. René ScharfeApr 8, 2009
  15. René ScharfeApr 8, 2009
  16. Junio C HamanoApr 8, 2009
  17. René ScharfeApr 13, 2009
  18. Nguyen Thai Ngoc DuyApr 14, 2009
  19. René ScharfeApr 14, 2009
  20. Junio C HamanoApr 16, 2009
  21. René ScharfeApr 17, 2009
  22. Junio C HamanoApr 18, 2009
  23. Junio C HamanoApr 8, 2009
  24. René ScharfeApr 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.