git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention

From
Ted Pavlic <ted@tedpavlic.com>
Date
Feb 11, 2009, 16:36 UTC
Message-ID
<4992FE78.6000206@tedpavlic.com>
In-Reply-To
<20090211162432.GF30949@spearce.org>
Show 6 quoted lines
> NAK.
>
> This script only runs in bash.  bash supports [...].  The
> prevailing convention in the script is to use [...].  Only
> 4 tests inside of __git_ps1 use "test", the rest of the code
> is using [...].
So this trumps Documentation/CodingGuidelines, which says:
  - We prefer "test" over "[ ... ]".
?

Thanks -- Ted

-- 
Ted Pavlic <ted@tedpavlic.com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.
Previous: Shawn O. PearceNext: Junio C Hamano
Message 13 of 16 in “completion: Convention updates and DIRTYSTATE fix”
  1. 0/3 completion: Convention updates and DIRTYSTATE fixTed Pavlic, Feb 11, 2009
  2. 1/3 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  3. 2/3 completion: Change "if [...]" to "if test ..." to match git conventionTed Pavlic, Feb 11, 2009
  4. 3/3 completion: Prevents GIT_PS1_DIRTYSTATE from breaking when CWD is .gitTed Pavlic, Feb 11, 2009
  5. 4/3 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  6. Shawn O. PearceFeb 11, 2009
  7. Shawn O. PearceFeb 11, 2009
  8. Ted PavlicFeb 11, 2009
  9. Junio C HamanoFeb 11, 2009
  10. Ted PavlicFeb 11, 2009
  11. Shawn O. PearceFeb 11, 2009
  12. Shawn O. PearceFeb 11, 2009
  13. Ted PavlicFeb 11, 2009
  14. Junio C HamanoFeb 11, 2009
  15. Junio C HamanoFeb 11, 2009
  16. Shawn O. PearceFeb 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.