Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention

From: Shawn O. Pearce <spearce@spearce.org>
Date: Feb 11, 2009, 16:24 UTC
Message-ID: <20090211162432.GF30949@spearce.org>
In-Reply-To: <1234366634-17900-3-git-send-email-ted@tedpavlic.com>

Ted Pavlic <ted@tedpavlic.com> wrote:

Show 7 quoted lines

> In the single case of:
> 
>     if [...] || [...]
> 
> changed to:
> 
>     if test ... || test ...

NAK.

This script only runs in bash. bash supports [...]. The prevailing convention in the script is to use [...]. Only 4 tests inside of __git_ps1 use "test", the rest of the code is using [...].

I would agree to a test->[...] conversion patch as its fairly small,
but not this one.  Too large, too much code churn, no benefit.

-- 
Shawn.