From: Ted Pavlic <ted@tedpavlic.com>
Date: Wed, 11 Feb 2009 16:36:08 GMT
Subject: Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention
Message-ID: <4992FE78.6000206@tedpavlic.com>
In-Reply-To: <20090211162432.GF30949@spearce.org>

> NAK.
>
> This script only runs in bash.  bash supports [...].  The
> prevailing convention in the script is to use [...].  Only
> 4 tests inside of __git_ps1 use "test", the rest of the code
> is using [...].

So this trumps Documentation/CodingGuidelines, which says:

  - We prefer "test" over "[ ... ]".

?

Thanks --
Ted

-- 
Ted Pavlic <ted@tedpavlic.com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.