git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] completion: For consistency, changed "git rev-parse" to __gitdir calls.

From
Shawn O. Pearce <spearce@spearce.org>
Date
Feb 11, 2009, 16:22 UTC
Message-ID
<20090211162235.GE30949@spearce.org>
In-Reply-To
<1234366634-17900-2-git-send-email-ted@tedpavlic.com>
Ted Pavlic <ted@tedpavlic.com> wrote:
> Signed-off-by: Ted Pavlic <ted@tedpavlic.com>
> ---
Acked-by: Shawn O. Pearce <spearce@spearce.org>
Show 28 quoted lines
>  contrib/completion/git-completion.bash |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index f44f63c..6bbe09a 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -80,7 +80,7 @@ __gitdir ()
>  # returns text to add to bash PS1 prompt (includes branch name)
>  __git_ps1 ()
>  {
> -	local g="$(git rev-parse --git-dir 2>/dev/null)"
> +	local g="$(__gitdir)"
>  	if [ -n "$g" ]; then
>  		local r
>  		local b
> @@ -1797,7 +1797,7 @@ _gitk ()
>  	__git_has_doubledash && return
>  
>  	local cur="${COMP_WORDS[COMP_CWORD]}"
> -	local g="$(git rev-parse --git-dir 2>/dev/null)"
> +	local g="$(__gitdir)"
>  	local merge=""
>  	if [ -f $g/MERGE_HEAD ]; then
>  		merge="--merge"
> -- 
> 1.6.1.2.390.gba743
> 
-- 
Shawn.
Previous: Junio C Hamano
Message 16 of 16 in “completion: Convention updates and DIRTYSTATE fix”
  1. 0/3 completion: Convention updates and DIRTYSTATE fixTed Pavlic, Feb 11, 2009
  2. 1/3 completion: For consistency, changed "git rev-parse" to __gitdir calls.Ted Pavlic, Feb 11, 2009
  3. 2/3 completion: Change "if [...]" to "if test ..." to match git conventionTed Pavlic, Feb 11, 2009
  4. 3/3 completion: Prevents GIT_PS1_DIRTYSTATE from breaking when CWD is .gitTed Pavlic, Feb 11, 2009
  5. 4/3 completion: More fixes to prevent unbound variable errors.Ted Pavlic, Feb 11, 2009
  6. Shawn O. PearceFeb 11, 2009
  7. Shawn O. PearceFeb 11, 2009
  8. Ted PavlicFeb 11, 2009
  9. Junio C HamanoFeb 11, 2009
  10. Ted PavlicFeb 11, 2009
  11. Shawn O. PearceFeb 11, 2009
  12. Shawn O. PearceFeb 11, 2009
  13. Ted PavlicFeb 11, 2009
  14. Junio C HamanoFeb 11, 2009
  15. Junio C HamanoFeb 11, 2009
  16. Shawn O. PearceFeb 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.