git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter

From
MZMarek Zawirski <marek.zawirski@gmail.com>
Date
Jun 2, 2008, 22:58 UTC
Message-ID
<48447B02.3040505@gmail.com>
In-Reply-To
<alpine.DEB.1.00.0806022313270.13507@racer.site.net>

Johannes Schindelin wrote: (...)

> You mean line-wrapping, right?  Is there a different 
> recommended column/line ratio for JGit than for Git?  Because some of your 
> later patches introduce lines longer than 80 columns/line.

Not only line-wrapping in fact. egit/jgit use it's own eclipse formatting template that define more than line-wrapping, even some spaces in javadocs as you may have seen. Actually I don't know is it 80 columns/line (but I suspect it may be), as I just use this formatter associated with project by simply pressing some keyboard shortcut. Maybe I simply missed some formatting, which patch do you mean? Some things however look strange after auto-formatting. While it may even look ugly for somebody I wouldn't try to change that by hand, to make other commiters lifes easier allowing them also just press "format" button ;)

Show 5 quoted lines
>>   Add getType() method to RevObject hierarchy
> 
> Was the idea not to use instanceof to be able to have multiple "types" per 
> object?  I.e. a commit object is of type commit, but also of type 
> object...

I'm not sure whether I understand you, but probably it was not what you mean. The only idea behind that was to refactor instanceofs to polymorphic getType() calls. It allows us mapping, indexing by type, using switches... without tones of code.

> BTW I really like the iterator implementation.
Thanks for looking in.
-- 
Marek Zawirski [zawir]
marek.zawirski@gmail.com
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 19 of 24 in “Extensions in core needed by PackWriter”
  1. 00/12 Extensions in core needed by PackWriterMarek Zawirski, Jun 2, 2008
  2. 01/12 Format PackFile classMarek Zawirski, Jun 2, 2008
  3. 02/12 Format PackIndex classMarek Zawirski, Jun 2, 2008
  4. 03/12 Format PackIndexV1 classMarek Zawirski, Jun 2, 2008
  5. 04/12 Add getType() method to RevObject hierarchyMarek Zawirski, Jun 2, 2008
  6. 05/12 Replace instanceof in WalkFetchConnection with getType()Marek Zawirski, Jun 2, 2008
  7. 06/12 Move PackFile.SIGNATURE to Constants.PACK_SIGNATUREMarek Zawirski, Jun 2, 2008
  8. 07/12 Add overload of fromRaw() in MutableObjectId accepting int[]Marek Zawirski, Jun 2, 2008
  9. 08/12 Copying constructor of MutableObjectIdMarek Zawirski, Jun 2, 2008
  10. 09/12 Add getSize() method to ObjectIdSubclassMapMarek Zawirski, Jun 2, 2008
  11. 10/12 Add getObjectCount() method to PackFileMarek Zawirski, Jun 2, 2008
  12. 11/12 Entries iterator in PackIndex and indirectly PackFileMarek Zawirski, Jun 2, 2008
  13. 12/12 Add PackIndex specific tests, currently only iterators testsMarek Zawirski, Jun 2, 2008
  14. Robin RosenbergJun 6, 2008
  15. 09/12 Add size() method to ObjectIdSubclassMapMarek Zawirski, Jun 7, 2008
  16. Robin RosenbergJun 6, 2008
  17. 04/12 Add getType() method to RevObject hierarchyMarek Zawirski, Jun 7, 2008
  18. Johannes SchindelinJun 2, 2008
  19. Marek ZawirskiJun 2, 2008
  20. Johannes SchindelinJun 2, 2008
  21. Robin RosenbergJun 6, 2008
  22. Marek ZawirskiJun 7, 2008
  23. Shawn O. PearceJun 7, 2008
  24. Robin RosenbergJun 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.