git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jun 7, 2008, 07:16 UTC
Message-ID
<20080607071613.GA12896@spearce.org>
In-Reply-To
<4849D115.5030602@gmail.com>
Marek Zawirski <marek.zawirski@gmail.com> wrote:
Show 9 quoted lines
> On Fri, Jun 6, 2008 at 3:24 PM, Robin Rosenberg 
> > 
> > I'm somewhat reluctant to reformatting patches though. 
> 
> Well, so should I remove these reformatting patches from series? (oouch!)
> 
> Actually, when I ran into formatting problem, Shawn suggested that I may 
> format PackFile as he was also touching this file - I much appreciated 
> this idea. PackIndex* formatting is however my own invention.

I'm in favor of reformatting, at least these two classes. Editing them without the formatting fixes is insanely annoying. But bulk reformatting all 118 files at once is nuts.

I'd rather do it one file at a time, when we touch it, and especially if it is fairly stable and isn't being actively hacked on by others.

> Isn't it somewhat annoying that formatting is inconsistent through
> project (especially line width in some places)? And that I almost have
> to block formatting shortcut to stop my pre-save/pre-commit habit?;)
Yes.  Yes it is.
-- 
Shawn.
Previous: Marek ZawirskiNext: Robin Rosenberg
Message 23 of 24 in “Extensions in core needed by PackWriter”
  1. 00/12 Extensions in core needed by PackWriterMarek Zawirski, Jun 2, 2008
  2. 01/12 Format PackFile classMarek Zawirski, Jun 2, 2008
  3. 02/12 Format PackIndex classMarek Zawirski, Jun 2, 2008
  4. 03/12 Format PackIndexV1 classMarek Zawirski, Jun 2, 2008
  5. 04/12 Add getType() method to RevObject hierarchyMarek Zawirski, Jun 2, 2008
  6. 05/12 Replace instanceof in WalkFetchConnection with getType()Marek Zawirski, Jun 2, 2008
  7. 06/12 Move PackFile.SIGNATURE to Constants.PACK_SIGNATUREMarek Zawirski, Jun 2, 2008
  8. 07/12 Add overload of fromRaw() in MutableObjectId accepting int[]Marek Zawirski, Jun 2, 2008
  9. 08/12 Copying constructor of MutableObjectIdMarek Zawirski, Jun 2, 2008
  10. 09/12 Add getSize() method to ObjectIdSubclassMapMarek Zawirski, Jun 2, 2008
  11. 10/12 Add getObjectCount() method to PackFileMarek Zawirski, Jun 2, 2008
  12. 11/12 Entries iterator in PackIndex and indirectly PackFileMarek Zawirski, Jun 2, 2008
  13. 12/12 Add PackIndex specific tests, currently only iterators testsMarek Zawirski, Jun 2, 2008
  14. Robin RosenbergJun 6, 2008
  15. 09/12 Add size() method to ObjectIdSubclassMapMarek Zawirski, Jun 7, 2008
  16. Robin RosenbergJun 6, 2008
  17. 04/12 Add getType() method to RevObject hierarchyMarek Zawirski, Jun 7, 2008
  18. Johannes SchindelinJun 2, 2008
  19. Marek ZawirskiJun 2, 2008
  20. Johannes SchindelinJun 2, 2008
  21. Robin RosenbergJun 6, 2008
  22. Marek ZawirskiJun 7, 2008
  23. Shawn O. PearceJun 7, 2008
  24. Robin RosenbergJun 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.