git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 09/12] Add getSize() method to ObjectIdSubclassMap

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Jun 6, 2008, 13:24 UTC
Message-ID
<200806061524.15823.robin.rosenberg@dewire.com>
In-Reply-To
<1212441883-12990-10-git-send-email-marek.zawirski@gmail.com>
måndagen den 2 juni 2008 23.24.40 skrev Marek Zawirski:
Show 14 quoted lines
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdSubclassMap.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdSubclassMap.java
> @@ -107,6 +107,15 @@ public class ObjectIdSubclassMap<V extends ObjectId> {
>  		size++;
>  	}
>  
> +	/**
> +	 * Returns number of objects in map.
> +	 * 
> +	 * @return number of objects in map
> +	 */
> +	public int size() {
> +		return size;
> +	}

Just the @return is usually enough for methods that simply return a value. If you have both the untagged part of the comment should explain much more. Patch 10 is a good example.

-- robin
Previous: Marek ZawirskiNext: Marek Zawirski
Message 14 of 24 in “Extensions in core needed by PackWriter”
  1. 00/12 Extensions in core needed by PackWriterMarek Zawirski, Jun 2, 2008
  2. 01/12 Format PackFile classMarek Zawirski, Jun 2, 2008
  3. 02/12 Format PackIndex classMarek Zawirski, Jun 2, 2008
  4. 03/12 Format PackIndexV1 classMarek Zawirski, Jun 2, 2008
  5. 04/12 Add getType() method to RevObject hierarchyMarek Zawirski, Jun 2, 2008
  6. 05/12 Replace instanceof in WalkFetchConnection with getType()Marek Zawirski, Jun 2, 2008
  7. 06/12 Move PackFile.SIGNATURE to Constants.PACK_SIGNATUREMarek Zawirski, Jun 2, 2008
  8. 07/12 Add overload of fromRaw() in MutableObjectId accepting int[]Marek Zawirski, Jun 2, 2008
  9. 08/12 Copying constructor of MutableObjectIdMarek Zawirski, Jun 2, 2008
  10. 09/12 Add getSize() method to ObjectIdSubclassMapMarek Zawirski, Jun 2, 2008
  11. 10/12 Add getObjectCount() method to PackFileMarek Zawirski, Jun 2, 2008
  12. 11/12 Entries iterator in PackIndex and indirectly PackFileMarek Zawirski, Jun 2, 2008
  13. 12/12 Add PackIndex specific tests, currently only iterators testsMarek Zawirski, Jun 2, 2008
  14. Robin RosenbergJun 6, 2008
  15. 09/12 Add size() method to ObjectIdSubclassMapMarek Zawirski, Jun 7, 2008
  16. Robin RosenbergJun 6, 2008
  17. 04/12 Add getType() method to RevObject hierarchyMarek Zawirski, Jun 7, 2008
  18. Johannes SchindelinJun 2, 2008
  19. Marek ZawirskiJun 2, 2008
  20. Johannes SchindelinJun 2, 2008
  21. Robin RosenbergJun 6, 2008
  22. Marek ZawirskiJun 7, 2008
  23. Shawn O. PearceJun 7, 2008
  24. Robin RosenbergJun 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.