git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: don't save the geometry to rc file on exit

From
Mark Levedahl <mlevedahl@gmail.com>
Date
Feb 24, 2008, 15:44 UTC
Message-ID
<47C190E3.6000407@gmail.com>
In-Reply-To
<18368.41742.689290.877767@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
Show 21 quoted lines
> Gerrit Pape writes:
>
>   
>> Saving the geometry can cause several inconveniences, e.g. when using a
>> temporary dual screen setup, or sharing ~/.gitk between multiple
>> systems.  Additionally it can be argued that window placement and sizing
>> are the tasks of the window manager.  So don't do that anymore.
>>     
>
> I myself find it useful to have gitk remember the size and layout of
> the various panes, so I won't be applying this patch.
>
> The saving/restoring of the window position was done by Mark Levedahl
> to make gitk work properly on Cygwin.  I agree it can be annoying on X
> and I would take a patch to inhibit the restoring of the window
> position when running under X.  I'd want an ack from Mark before
> making that change more generally.
>
> Paul.
>
>

I can only offer to test the proposed patch, I am unable to predict what will or won't trip up the buggy geometry engine in Cygwin's Tk. I do remember I had trouble finding a way to restore the size but not the position of the main window on Cygwin: that doesn't mean it can't be done (logically, it should be easy), just that I didn't find the right spell or incantation that would work. I'll also admit to not having tried after I got to a completely working geometry solution, so perhaps just restoring the size without position will now work on Cygwin.

Using the saved panel sizes in conjunction with the default window size yields an unusable screen: many elements are obscured. The same occurs using the defaults altogether: either way the user must resize and adjust things to get to a workable layout. So, I am very opposed to disabling the memory altogether. Also, I have a number of X apps that remember their layout, so gitk's current behavior is not (at least to me) an aberration and I would like that behavior to at least remain an option.

Mark
Previous: Paul MackerrasNext: Edgar Toernig
Message 9 of 26 in “Bug in gitk - can post the window off screen”
  1. Tommy ThornFeb 7, 2008
  2. Shawn O. PearceFeb 7, 2008
  3. Robin RosenbergFeb 7, 2008
  4. Gerrit PapeFeb 7, 2008
  5. gitk: don't save the geometry to rc file on exitGerrit Pape, Feb 23, 2008
  6. Robin RosenbergFeb 23, 2008
  7. Jonathan del StrotherFeb 23, 2008
  8. Paul MackerrasFeb 23, 2008
  9. Mark LevedahlFeb 24, 2008
  10. Edgar ToernigFeb 24, 2008
  11. Paul MackerrasMar 6, 2008
  12. Jonathan del StrotherMar 6, 2008
  13. Paul MackerrasMar 6, 2008
  14. Mark LevedahlMar 7, 2008
  15. martin f krafftMar 7, 2008
  16. Paul MackerrasMar 8, 2008
  17. martin f krafftMar 10, 2008
  18. David TweedMar 10, 2008
  19. martin f krafftFeb 25, 2008
  20. Paul MackerrasFeb 25, 2008
  21. martin f krafftFeb 25, 2008
  22. Mark LevedahlFeb 25, 2008
  23. martin f krafftFeb 25, 2008
  24. Martin LanghoffFeb 25, 2008
  25. Robin RosenbergFeb 25, 2008
  26. A Large Angry SCMFeb 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.