Re: [PATCH] gitk: don't save the geometry to rc file on exit

From: martin f krafft <madduck@madduck.net>
Date: Feb 25, 2008, 08:07 UTC
Message-ID: <20080225080739.GA13610@piper.oerlikon.madduck.net>
In-Reply-To: <18368.41742.689290.877767@cargo.ozlabs.ibm.com>

also sprach Paul Mackerras <paulus@samba.org> [2008.02.23.2349 +0100]:

Show 14 quoted lines

> > Saving the geometry can cause several inconveniences, e.g. when
> > using a temporary dual screen setup, or sharing ~/.gitk between
> > multiple systems.  Additionally it can be argued that window
> > placement and sizing are the tasks of the window manager.  So
> > don't do that anymore.
> 
> I myself find it useful to have gitk remember the size and layout
> of the various panes, so I won't be applying this patch.
> 
> The saving/restoring of the window position was done by Mark
> Levedahl to make gitk work properly on Cygwin.  I agree it can be
> annoying on X and I would take a patch to inhibit the restoring of
> the window position when running under X.  I'd want an ack from
> Mark before making that change more generally.

May I suggest that such a patch actually disables writing of the config file, so that we won't get conflicts every time you sync config files via home-in-git?

Of course I offer to look into this once Mark approves.

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"if there's anything more important than my ego,
 i want it caught and shot now."
                                                -- zaphod beeblebrox
 
spamtraps: madduck.bogus@madduck.net