git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: don't save the geometry to rc file on exit

From
Paul Mackerras <paulus@samba.org>
Date
Mar 8, 2008, 11:11 UTC
Message-ID
<18386.29775.512557.202621@cargo.ozlabs.ibm.com>
In-Reply-To
<20080307111144.GA18108@piper.oerlikon.madduck.net>
martin f krafft writes:
Show 5 quoted lines
> I can confirm that the behaviour is much better: the window size is
> restored, as is the position, but it gives preference to the
> Xinerama head. You'd think it restores at the same *relative*
> position on the current head, but it actually just restores
> somewhere $,1rt(B I cannot figure out the behaviour.
The position is entirely up to your window manager.
> However, I still wonder why we have to do this at all.
Well, try it without... :)

Restoring the overall window size and the positions of the sashes of the panedwindows is the simplest and most reliable method I have found for making the window come back the way the user last set it.

Show 5 quoted lines
> I understand
> that Cygwin has issues and needs this code, but couldn't it then be
> made to run only on Cygwin, such that on "proper" Unix systems, the
> config file is *not* updated every time I move the window before
> closing the application?
What's the issue with updating the config file?
> As I said earlier, this is really the job
> of a window manager, *not* a configuration option. If your window
> manager cannot restore the window to a size you control, then it's
> broken. Let's not hack applications to work around that, please.

I disagree. It's not a window manager's job to tell an application how big its window should be.

Paul.
Previous: martin f krafftNext: martin f krafft
Message 16 of 26 in “Bug in gitk - can post the window off screen”
  1. Tommy ThornFeb 7, 2008
  2. Shawn O. PearceFeb 7, 2008
  3. Robin RosenbergFeb 7, 2008
  4. Gerrit PapeFeb 7, 2008
  5. gitk: don't save the geometry to rc file on exitGerrit Pape, Feb 23, 2008
  6. Robin RosenbergFeb 23, 2008
  7. Jonathan del StrotherFeb 23, 2008
  8. Paul MackerrasFeb 23, 2008
  9. Mark LevedahlFeb 24, 2008
  10. Edgar ToernigFeb 24, 2008
  11. Paul MackerrasMar 6, 2008
  12. Jonathan del StrotherMar 6, 2008
  13. Paul MackerrasMar 6, 2008
  14. Mark LevedahlMar 7, 2008
  15. martin f krafftMar 7, 2008
  16. Paul MackerrasMar 8, 2008
  17. martin f krafftMar 10, 2008
  18. David TweedMar 10, 2008
  19. martin f krafftFeb 25, 2008
  20. Paul MackerrasFeb 25, 2008
  21. martin f krafftFeb 25, 2008
  22. Mark LevedahlFeb 25, 2008
  23. martin f krafftFeb 25, 2008
  24. Martin LanghoffFeb 25, 2008
  25. Robin RosenbergFeb 25, 2008
  26. A Large Angry SCMFeb 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.