Re: [PATCH] gitk: don't save the geometry to rc file on exit

From: martin f krafft <madduck@madduck.net>
Date: Mar 7, 2008, 11:11 UTC
Message-ID: <20080307111144.GA18108@piper.oerlikon.madduck.net>
In-Reply-To: <18383.57540.26282.526111@cargo.ozlabs.ibm.com>

also sprach Paul Mackerras <paulus@samba.org> [2008.03.06.1317 +0100]:

> Here's a patch for people to test.  It only restores the width and
> height, and limits the width and height to be at most the width and
> height of the screen.  It seems to work fine under X; I would be
> interested to know what happens under macos and windows.

I can confirm that the behaviour is much better: the window size is restored, as is the position, but it gives preference to the Xinerama head. You'd think it restores at the same *relative* position on the current head, but it actually just restores somewhere — I cannot figure out the behaviour.

However, I still wonder why we have to do this at all. I understand that Cygwin has issues and needs this code, but couldn't it then be made to run only on Cygwin, such that on "proper" Unix systems, the config file is *not* updated every time I move the window before closing the application? As I said earlier, this is really the job of a window manager, *not* a configuration option. If your window manager cannot restore the window to a size you control, then it's broken. Let's not hack applications to work around that, please.

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
$complex->{'data'}[$structures][$in_perl] = @{$can{'be'}->[$painful]};
 
spamtraps: madduck.bogus@madduck.net