Re: git and peer review

From: Ping Yin <pkufranky@gmail.com>
Date: May 3, 2008, 14:03 UTC
Message-ID: <46dff0320805030703g68de70edtc0371b2261059827@mail.gmail.com>
In-Reply-To: <18071eea0805030654j42c21212wd1ccf4df42662000@mail.gmail.com>

On Sat, May 3, 2008 at 9:54 PM, Thomas Adam <thomas.adam22@gmail.com> wrote:

Show 10 quoted lines

>  Assuming this is enforced either through a template (see:
>  commit.template in git-config(1)), or as part of being added by the
>  committer, then in GIT 1.5.4 onwards there's a commit-msg hook which
>  will do this for you.  Something like:
>
>  test "" = "$(grep '^Reviewed-by: ')" || {
>     echo >&2 "Message must have a Reviewed-by line present."
>     exit
>
> }

Actually, i want a way to rewrite the history or reapply the patch series and add the reviewed-by line then. Before that, i can commit arbitrarily without any limitation.

>
>  >  And one question, how to add a "Reviewed-by" line automatically?
>
>  There's an example of that by way of a SOB in the commit-msg hook.

Sorry, but what does SOB stand for?

-- 
Ping Yin