git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git and peer review

From
Seth Falcon <seth@userprimary.net>
Date
May 17, 2008, 21:30 UTC
Message-ID
<20080517213039.GR396@ziti.local>
In-Reply-To
<87k5i9u8f1.fsf@nav-akl-pcn-343.mitacad.com>
* On 2008-05-05 at 08:21 +1200 Toby Allsopp wrote:
> I do something similar using git filter-branch --msg-filter.  I have a
> little shell script call git-add-checked (our convention is to have a
> "checked: " line in the commit message):

That's a useful script, thanks for posting it. I'd like to make it a bit safer to use -- the first time I tried it I didn't give any branch limiting args and it started filtering a lot of history :-P

What I would like is a way for the script to determine the appropriate tracking branch. So that the usage would look like:

   git mark-reviewed someone@userprimary.net

and it would figure out whether it should do trunk.. or release-1.3.., etc. Can anyone point me in the right direction?

-- 
Seth Falcon | http://userprimary.net/user/
Previous: Karl HasselströmNext: Shawn O. Pearce
Message 9 of 11 in “git and peer review”
  1. Ping YinMay 3, 2008
  2. Thomas AdamMay 3, 2008
  3. Ping YinMay 3, 2008
  4. Frodo BagginsMay 3, 2008
  5. Ping YinMay 3, 2008
  6. Toby AllsoppMay 4, 2008
  7. Ping YinMay 5, 2008
  8. Karl HasselströmMay 5, 2008
  9. Seth FalconMay 17, 2008
  10. Shawn O. PearceMay 19, 2008
  11. Seth FalconMay 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.