Re: git and peer review

From: Karl Hasselström <kha@treskal.com>
Date: May 5, 2008, 13:48 UTC
Message-ID: <20080505134831.GA12733@diana.vm.bytemark.co.uk>
In-Reply-To: <87k5i9u8f1.fsf@nav-akl-pcn-343.mitacad.com>

On 2008-05-05 08:21:54 +1200, Toby Allsopp wrote:

Show 8 quoted lines

> At the moment I'm using gitk to step through the patch series along
> with the patch to gitk that adds a context-menu entry to lauch an
> external diff tool when a side-by-side diff is easier to read.
>
> This is okay, but it's a bit of a pain to make changes while the
> review is in progress (git rebase -i, s/pick/edit on the appropriate
> line, make changes, git commit --amend, git rebase --continue).
> Perhaps stgit or guilt would help with this.

Yes, StGit helps here. "stg edit <patchname>" lets you edit the commit message of any patch.

( In the master branch, but not yet released, is an emacs mode for
  StGit. It displays the list of patches (name + first line of commit
  message), and you can press "=" to view the patch (including the
  commit message), and "e" to edit its commit message. )

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle