git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git and peer review

From
Ping Yin <pkufranky@gmail.com>
Date
May 3, 2008, 01:02 UTC
Message-ID
<46dff0320805021802i1a29becflcae901315035a77d@mail.gmail.com>

I have tried many online review tools: cucible, reviewboard and smartcollaborator. The are both great. However, they can't satisfy all my requirements:

1. poor git support
2. When reviewing changes between revision (or commit for git) a and
revision b, they display all changes as a single diff instead of one
diff for each intermediate revision

So finally, i decide to use git itself as the reviewing tool if i can't find better.

I am in a company environment and i want to enforce a policy that every commit must be reviewed before pushed to central repository. I think i can use hooks to enforce such kind of policy.

One way i want to try is to check in the hook whether every pushed commit has a "Reviewed-by " line . Any suggestion?

And one question, how to add a "Reviewed-by" line automatically?

The reviewers sit near each other, so we do face-to-face peer review and don't pass patches by email. Say, i have prepared a patch series,

Case 1
    I ask someone to review my patches at my machine. If the review
passes, i have to add Reviewed-by line to each commit and then merge
it to the master branch. However, i find no easy way to add
reviewed-by line. Maybe adding --reviewed-by  option to cherry-pick or
rebase or merge?
Case 2
   The reviewer is the maintainer, so i ask him to pull and review. So
now it is his turn to add review-by line. But still, how?
-- 
Ping Yin
Next: Thomas Adam
Message 1 of 11 in “git and peer review”
  1. Ping YinMay 3, 2008
  2. Thomas AdamMay 3, 2008
  3. Ping YinMay 3, 2008
  4. Frodo BagginsMay 3, 2008
  5. Ping YinMay 3, 2008
  6. Toby AllsoppMay 4, 2008
  7. Ping YinMay 5, 2008
  8. Karl HasselströmMay 5, 2008
  9. Seth FalconMay 17, 2008
  10. Shawn O. PearceMay 19, 2008
  11. Seth FalconMay 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.