Re: [PATCH 21/22] teach the merge algorithm about cache iterators
- From
- Chuck Lever <cel@citi.umich.edu>
- Date
- Sep 13, 2005, 00:02 UTC
- Message-ID
- <4326170E.5040509@citi.umich.edu>
- In-Reply-To
- <Pine.LNX.4.63.0509121633480.23242@iabervon.org>
Daniel Barkalow wrote:
Show 11 quoted lines
> On Mon, 12 Sep 2005, Chuck Lever wrote: >>For now, we simply replace indpos with a cache cursor. Likely more >>changes will be needed after we successfully replace the cache array >>with an abstract data type. > > The right order is probably to add the concept of a cache that isn't the > one that normal functions deal with, have read_cache_unmerged return such > a thing, call cc_init with that, and rip out all of the removal and > position adjustment code. Then read_tree won't care at all about the > internal structure of the cache type, and it can be replaced without any > problem.
yeah, i've come to the same conclusion, and started screwing with this idea today.
begin:vcard fn:Chuck Lever n:Lever;Charles org:Network Appliance, Incorporated;Linux NFS Client Development adr:535 West William Street, Suite 3100;;Center for Information Technology Integration;Ann Arbor;MI;48103-4943;USA email;internet:cel@citi.umich.edu title:Member of Technical Staff tel;work:+1 734 763-4415 tel;fax:+1 734 763 4434 tel;home:+1 734 668-1089 x-mozilla-html:FALSE url:http://www.monkey.org/~cel/ version:2.1 end:vcard