git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, "warning: ")

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Mar 24, 2009, 01:25 UTC
Message-ID
<40aa078e0903231825w54c9dca2xc68a849d245916a4@mail.gmail.com>
In-Reply-To
<9287282d966904f06ae4b3d7cfdf1d79eb645b69.1237856682.git.vmiklos@frugalware.org>
On Tue, Mar 24, 2009 at 2:09 AM, Miklos Vajna <vmiklos@frugalware.org> wrote:
Show 7 quoted lines
> @@ -2932,8 +2932,7 @@ static int write_out_one_reject(struct patch *patch)
>        cnt = strlen(patch->new_name);
>        if (ARRAY_SIZE(namebuf) <= cnt + 5) {
>                cnt = ARRAY_SIZE(namebuf) - 5;
> -               fprintf(stderr,
> -                       "warning: truncating .rej filename to %.*s.rej",
> +               warning("truncating .rej filename to %.*s.rej",
Again, doesn't this change the output?
-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
Previous: Erik Faye-LundNext: Jeff King
Message 14 of 16 in “fprintf(stderr, "warning: ") -> warning() patches”
  1. 0/9 fprintf(stderr, "warning: ") -> warning() patchesMiklos Vajna, Mar 24, 2009
  2. 1/9 http-push: using error() and warning() as appropriateMiklos Vajna, Mar 24, 2009
  3. 2/9 builtin-apply: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  4. 3/9 builtin-checkout: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  5. 4/9 builtin-fetch-pack: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  6. 5/9 builtin-init-db: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  7. 6/9 builtin-rm: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  8. 7/9 builtin-show-branch: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  9. 8/9 builtin-show-ref: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  10. 9/9 refs: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  11. Erik Faye-LundMar 24, 2009
  12. Miklos VajnaMar 24, 2009
  13. Erik Faye-LundMar 24, 2009
  14. Erik Faye-LundMar 24, 2009
  15. Jeff KingMar 24, 2009
  16. Junio C HamanoMar 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.