Re: [PATCH 9/9] refs: use warning() instead of fprintf(stderr, "warning: ")
OK, sorry for not reading the old discussion before commenting. :)
On Tue, Mar 24, 2009 at 2:23 AM, Miklos Vajna <vmiklos@frugalware.org> wrote:
Show 17 quoted lines
> On Tue, Mar 24, 2009 at 02:17:24AM +0100, Erik Faye-Lund <kusmabite@googlemail.com> wrote:
>> > @@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
>> >
>> > err = unlink(git_path("logs/%s", lock->ref_name));
>> > if (err && errno != ENOENT)
>> > - fprintf(stderr, "warning: unlink(%s) failed: %s",
>> > + warning("unlink(%s) failed: %s",
>>
>> Doesn't this add a newline? The original string doesn't have a '\n' at
>> the end of the format-field, but AFAIK warning() terminates with one.
>> I'm not saying it's a problem, I'm just pointing it out.
>
> Yes, it adds. As Jeff pointed out earlier in this thread, the lack of
> newline was a bug:
>
> http://article.gmane.org/gmane.comp.version-control.git/110783
>--
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
Erik Faye-Lund <kusmabite@googlemail.com>