git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/9] http-push: using error() and warning() as appropriate

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Mar 24, 2009, 01:09 UTC
Message-ID
<1fcc4848dd7a24f846bb302bbb555bf1bac795a5.1237856682.git.vmiklos@frugalware.org>
In-Reply-To
<cover.1237856682.git.vmiklos@frugalware.org>

Change three occurences of using inconsistent error/warning reporting by using the relevant error() / warning() calls to be consitent with the rest of the code.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 http-push.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/http-push.c b/http-push.c
index 48e5f38..e6bd01a 100644
--- a/http-push.c
+++ b/http-push.c
@@ -759,7 +759,7 @@ static void finish_request(struct transfer_request *request)
 			}
 		} else {
 			if (request->http_code == 416)
-				fprintf(stderr, "Warning: requested range invalid; we may already have all the data.\n");
+				warning("requested range invalid; we may already have all the data.");
 
 			git_inflate_end(&request->stream);
 			git_SHA1_Final(request->real_sha1, &request->c);
@@ -1616,7 +1616,7 @@ static int locking_available(void)
 			}
 			XML_ParserFree(parser);
 			if (!lock_flags)
-				error("Error: no DAV locking support on %s",
+				error("no DAV locking support on %s",
 				      remote->url);
 
 		} else {
@@ -2225,7 +2225,7 @@ int main(int argc, char **argv)
 		if (info_ref_lock)
 			remote->can_update_info_refs = 1;
 		else {
-			fprintf(stderr, "Error: cannot lock existing info/refs\n");
+			error("cannot lock existing info/refs");
 			rc = 1;
 			goto cleanup;
 		}
-- 
1.6.2
Previous: Miklos VajnaNext: Miklos Vajna
Message 2 of 16 in “fprintf(stderr, "warning: ") -> warning() patches”
  1. 0/9 fprintf(stderr, "warning: ") -> warning() patchesMiklos Vajna, Mar 24, 2009
  2. 1/9 http-push: using error() and warning() as appropriateMiklos Vajna, Mar 24, 2009
  3. 2/9 builtin-apply: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  4. 3/9 builtin-checkout: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  5. 4/9 builtin-fetch-pack: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  6. 5/9 builtin-init-db: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  7. 6/9 builtin-rm: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  8. 7/9 builtin-show-branch: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  9. 8/9 builtin-show-ref: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  10. 9/9 refs: use warning() instead of fprintf(stderr, "warning: ")Miklos Vajna, Mar 24, 2009
  11. Erik Faye-LundMar 24, 2009
  12. Miklos VajnaMar 24, 2009
  13. Erik Faye-LundMar 24, 2009
  14. Erik Faye-LundMar 24, 2009
  15. Jeff KingMar 24, 2009
  16. Junio C HamanoMar 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.