git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] get_ref_states: strdup entries and free util in stale list

From
Bert Wesarg <bert.wesarg@googlemail.com>
Date
Dec 1, 2009, 09:05 UTC
Message-ID
<36ca99e90912010105r428a7bfdw63928e8a5515bd1d@mail.gmail.com>
In-Reply-To
<alpine.DEB.1.00.0912010934120.4985@pacific.mpi-cbg.de>

On Tue, Dec 1, 2009 at 09:35, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 7 quoted lines
> Hi,
>
> On Tue, 1 Dec 2009, Bert Wesarg wrote:
>
>> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>
> Thanks.  I trust you ran the test suite with valgrind just to make sure?

Not the test suite. But my use case where I found the problem (Ie. cut-off branch names) which was 'git remote show <remote>'. There are still invalid reads of size 4. I think the problem is the flex array member of 'struct ref' and strlen(). If its worth I can look into this.

Bert
>
> Ciao,
> Dscho
>
Previous: Johannes SchindelinNext: Bert Wesarg
Message 10 of 12 in “get_ref_states: strdup entries and free util in stale list”
  1. get_ref_states: strdup entries and free util in stale listBert Wesarg, Nov 30, 2009
  2. Junio C HamanoDec 1, 2009
  3. Bert WesargDec 1, 2009
  4. Junio C HamanoDec 1, 2009
  5. Bert WesargDec 1, 2009
  6. Junio C HamanoDec 1, 2009
  7. Bert WesargDec 1, 2009
  8. Junio C HamanoDec 1, 2009
  9. Johannes SchindelinDec 1, 2009
  10. Bert WesargDec 1, 2009
  11. Bert WesargDec 1, 2009
  12. Bert WesargDec 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.