From: Bert Wesarg Date: Tue, 01 Dec 2009 09:05:41 GMT Subject: Re: [PATCH] get_ref_states: strdup entries and free util in stale list Message-ID: <36ca99e90912010105r428a7bfdw63928e8a5515bd1d@mail.gmail.com> In-Reply-To: On Tue, Dec 1, 2009 at 09:35, Johannes Schindelin wrote: > Hi, > > On Tue, 1 Dec 2009, Bert Wesarg wrote: > >> Signed-off-by: Bert Wesarg > > Thanks.  I trust you ran the test suite with valgrind just to make sure? Not the test suite. But my use case where I found the problem (Ie. cut-off branch names) which was 'git remote show '. There are still invalid reads of size 4. I think the problem is the flex array member of 'struct ref' and strlen(). If its worth I can look into this. Bert > > Ciao, > Dscho >