git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] get_ref_states: strdup entries and free util in stale list

From
Bert Wesarg <bert.wesarg@googlemail.com>
Date
Nov 30, 2009, 23:57 UTC
Message-ID
<0458f16c6ce906997aaf357c0c7368841ae83c36.1259625072.git.bert.wesarg@googlemail.com>
Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
---
 builtin-remote.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index 7916626..bb72e27 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -272,7 +272,9 @@ static int get_ref_states(const struct ref *remote_refs, struct ref_states *stat
 			die("Could not get fetch map for refspec %s",
 				states->remote->fetch_refspec[i]);
 
-	states->new.strdup_strings = states->tracked.strdup_strings = 1;
+	states->new.strdup_strings =
+	states->tracked.strdup_strings =
+	states->stale.strdup_strings = 1;
 	for (ref = fetch_map; ref; ref = ref->next) {
 		unsigned char sha1[20];
 		if (!ref->peer_ref || read_ref(ref->peer_ref->name, sha1))
@@ -768,7 +770,7 @@ static void clear_push_info(void *util, const char *string)
 static void free_remote_ref_states(struct ref_states *states)
 {
 	string_list_clear(&states->new, 0);
-	string_list_clear(&states->stale, 0);
+	string_list_clear(&states->stale, 1);
 	string_list_clear(&states->tracked, 0);
 	string_list_clear(&states->heads, 0);
 	string_list_clear_func(&states->push, clear_push_info);
-- 
1.6.6.rc0.253.g1ec3
Next: Junio C Hamano
Message 1 of 12 in “get_ref_states: strdup entries and free util in stale list”
  1. get_ref_states: strdup entries and free util in stale listBert Wesarg, Nov 30, 2009
  2. Junio C HamanoDec 1, 2009
  3. Bert WesargDec 1, 2009
  4. Junio C HamanoDec 1, 2009
  5. Bert WesargDec 1, 2009
  6. Junio C HamanoDec 1, 2009
  7. Bert WesargDec 1, 2009
  8. Junio C HamanoDec 1, 2009
  9. Johannes SchindelinDec 1, 2009
  10. Bert WesargDec 1, 2009
  11. Bert WesargDec 1, 2009
  12. Bert WesargDec 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.