Re: [PATCH] get_ref_states: strdup entries and free util in stale list

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Dec 1, 2009, 18:14 UTC
Message-ID: <36ca99e90912011014sd7372d0yc234873a26c2ae43@mail.gmail.com>
In-Reply-To: <7v8wdm1ui1.fsf@alter.siamese.dyndns.org>

On Tue, Dec 1, 2009 at 18:20, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Bert Wesarg <bert.wesarg@googlemail.com> writes:
>
>>>  - The ref abbrev_branch() is called and the address of whose substring is
>>>   taken to be used as "name" in handle_one_branch() is refspec.src, but
>>>   what goes to .util is refname that is refspec.dst---they are different
>>>   strings and one is not a substring of the other.
>> I don't see you point here.
>
> Of course you don't ;-) because we were looking at different versions.
>
> I wanted to apply the same fix to both maint and master.  For the code in
> 'master' your observation is 100% correct.

A quick test with my use case does not show errors in the maint branch. So it should not be needed (except the memory leak fix of the .util member). And valgrind confirms this.

Bert