git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)

From
Bert Wesarg <bert.wesarg@googlemail.com>
Date
Nov 21, 2008, 12:15 UTC
Message-ID
<36ca99e90811210415g7b50c5c1m3185bf19cab104aa@mail.gmail.com>
In-Reply-To
<20081121120609.GA10326@piper.oerlikon.madduck.net>
On Fri, Nov 21, 2008 at 13:06, martin f krafft <madduck@debian.org> wrote:
> I think you wanted to CC Petr, not Junio. It's also useful to CC
> Debian bugs if you know of them. :)

I CC'ed Junio, because I think this git rev-parse --git-dir is a bug. For example you can try starting git gui inside a .git dir.

Show 16 quoted lines
>
> also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1019 +0100]:
>> I really second this. Plus, I think its crucial to check that we are
>> not inside the .git directory before setting up topgit. Because git
>> rev-parse --git-dir only works in the top .git dir, not deeper (i.e.
>> inside .git/refs) and will always return ".".
>>
>>       $(git rev-parse --is-inside-work-tree) ||
>>               die "Not in a git working directory"
>
> Thanks, noted. I am still working on this patch, since
> evaluating $argv/checking for --help at this early stage basically
> requires a rewrite of the CLI parsing, ideally using POSIX getopt or
> something similar, which takes much of the load away.
>
> Anyway, Patch for your proposal forthcoming.

A patch would depent on your --help patch, Because help should work everywhere. So either I wait for you or do do it.

Bert
Show 18 quoted lines
>
> --
>  .''`.   martin f. krafft <madduck@debian.org>
> : :'  :  proud Debian developer, author, administrator, and user
> `. `'`   http://people.debian.org/~madduck - http://debiansystem.info
>  `-  Debian - when you have better things to do than fixing systems
>
> (a)bort, (r)etry, (p)retend this never happened
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkkmpDAACgkQIgvIgzMMSnUSKgCghXE+J9KegZ03tetnM3TIcyeM
> zn0AoJmYVzh/Kjxk7NFEpQw7USR0daXy
> =xl31
> -----END PGP SIGNATURE-----
>
>
Previous: martin f. krafftNext: Bert Wesarg
Message 13 of 16 in “[TopGit] Improve help output”
  1. martin f. krafftNov 19, 2008
  2. Check for help invocation before setupmartin f. krafft, Nov 19, 2008
  3. Change tg help exit code to 0martin f. krafft, Nov 19, 2008
  4. Check for cmddir earliermartin f. krafft, Nov 19, 2008
  5. Print help output when no command is givenmartin f. krafft, Nov 19, 2008
  6. Petr BaudisNov 19, 2008
  7. martin f krafftNov 19, 2008
  8. Petr BaudisNov 19, 2008
  9. martin f krafftNov 20, 2008
  10. Bert WesargNov 21, 2008
  11. TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)martin f krafft, Nov 21, 2008
  12. Ensure we are inside a Git worktreemartin f. krafft, Nov 21, 2008
  13. Bert WesargNov 21, 2008
  14. Bert WesargNov 21, 2008
  15. martin f krafftNov 21, 2008
  16. martin f krafftNov 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.