git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [TopGit PATCH] Check for help invocation before setup

From
Bert Wesarg <bert.wesarg@googlemail.com>
Date
Nov 21, 2008, 09:19 UTC
Message-ID
<36ca99e90811210119s215513a8m7c12c8d55fd54d70@mail.gmail.com>
In-Reply-To
<1227110623-4474-2-git-send-email-madduck@debian.org>
Hi,
On Wed, Nov 19, 2008 at 17:03, martin f. krafft <madduck@debian.org> wrote:
Show 5 quoted lines
> The user ought to be able to call `tg help` from anywhere in the
> filesystem, not just Git repositories, so the help parsing has to happen
> before the calls to git git binary.
>
> Debian bug: #501982

I really second this. Plus, I think its crucial to check that we are not inside the .git directory before setting up topgit. Because git rev-parse --git-dir only works in the top .git dir, not deeper (i.e. inside .git/refs) and will always return ".".

	$(git rev-parse --is-inside-work-tree) ||
		die "Not in a git working directory"
Bert
Previous: martin f krafftNext: martin f krafft
Message 10 of 16 in “[TopGit] Improve help output”
  1. martin f. krafftNov 19, 2008
  2. Check for help invocation before setupmartin f. krafft, Nov 19, 2008
  3. Change tg help exit code to 0martin f. krafft, Nov 19, 2008
  4. Check for cmddir earliermartin f. krafft, Nov 19, 2008
  5. Print help output when no command is givenmartin f. krafft, Nov 19, 2008
  6. Petr BaudisNov 19, 2008
  7. martin f krafftNov 19, 2008
  8. Petr BaudisNov 19, 2008
  9. martin f krafftNov 20, 2008
  10. Bert WesargNov 21, 2008
  11. TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)martin f krafft, Nov 21, 2008
  12. Ensure we are inside a Git worktreemartin f. krafft, Nov 21, 2008
  13. Bert WesargNov 21, 2008
  14. Bert WesargNov 21, 2008
  15. martin f krafftNov 21, 2008
  16. martin f krafftNov 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.