Re: [TopGit PATCH] Check for help invocation before setup

From: Petr Baudis <pasky@suse.cz>
Date: Nov 19, 2008, 18:39 UTC
Message-ID: <20081119183902.GX10491@machine.or.cz>
In-Reply-To: <20081119183234.GA19781@piper.oerlikon.madduck.net>

On Wed, Nov 19, 2008 at 07:32:34PM +0100, martin f krafft wrote:

Show 30 quoted lines

> also sprach Petr Baudis <pasky@suse.cz> [2008.11.19.1924 +0100]:
> > > +args_saved="$@"
> > > +while [ -n "$1" ]; do
> > > +	case "$1" in
> > > +	help|--help|-h)
> > > +		shift
> > > +		do_help "$1"
> > > +		exit 1;;
> > > +	esac
> > > +	shift
> > > +done
> > > +set -- $args_saved
> > > +unset args_saved
> > >  
> > >  ## Initial setup
> > 
> > Huh, why do you actually need $args_saved at all? :-) This is bound to
> > do horrible things with space-containing arguments etc., I think. You
> > don't need to do the outer shift and then drop $args_saved altogether,
> > no?
> 
> I figured I need to restore $@ for others to consume, e.g. when you
> check for -r later.
> 
> The challenge is to identify help|--help|-h anywhere on the command
> line. Thus, you need to iterate, or do some weird matching against
> $*.
> 
> When you iterate in a for loop, it's not easy to get at the next
> argument, except if you use a state machine. I wanted to avoid that.

Oh, oops - I missed the loop, I should get some lunch. ;-) Thus, something like this?

	check_help() { while [ -n "$1" ]; do ...; shift; done }
	check_help "$@"

-- 
				Petr "Pasky" Baudis
People who take cold baths never have rheumatism, but they have
cold baths.