git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [TopGit PATCH] Check for help invocation before setup

From
Petr Baudis <pasky@suse.cz>
Date
Nov 19, 2008, 18:24 UTC
Message-ID
<20081119182436.GB10544@machine.or.cz>
In-Reply-To
<1227110623-4474-2-git-send-email-madduck@debian.org>
On Wed, Nov 19, 2008 at 05:03:40PM +0100, martin f. krafft wrote:
Show 24 quoted lines
> diff --git a/tg.sh b/tg.sh
> index 2961106..40c4ab7 100644
> --- a/tg.sh
> +++ b/tg.sh
> @@ -235,6 +235,20 @@ do_help()
>  	fi
>  }
>  
> +## Startup
> +
> +args_saved="$@"
> +while [ -n "$1" ]; do
> +	case "$1" in
> +	help|--help|-h)
> +		shift
> +		do_help "$1"
> +		exit 1;;
> +	esac
> +	shift
> +done
> +set -- $args_saved
> +unset args_saved
>  
>  ## Initial setup

Huh, why do you actually need $args_saved at all? :-) This is bound to do horrible things with space-containing arguments etc., I think. You don't need to do the outer shift and then drop $args_saved altogether, no?

-- 
				Petr "Pasky" Baudis
People who take cold baths never have rheumatism, but they have
cold baths.
Previous: martin f. krafftNext: martin f krafft
Message 6 of 16 in “[TopGit] Improve help output”
  1. martin f. krafftNov 19, 2008
  2. Check for help invocation before setupmartin f. krafft, Nov 19, 2008
  3. Change tg help exit code to 0martin f. krafft, Nov 19, 2008
  4. Check for cmddir earliermartin f. krafft, Nov 19, 2008
  5. Print help output when no command is givenmartin f. krafft, Nov 19, 2008
  6. Petr BaudisNov 19, 2008
  7. martin f krafftNov 19, 2008
  8. Petr BaudisNov 19, 2008
  9. martin f krafftNov 20, 2008
  10. Bert WesargNov 21, 2008
  11. TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup)martin f krafft, Nov 21, 2008
  12. Ensure we are inside a Git worktreemartin f. krafft, Nov 21, 2008
  13. Bert WesargNov 21, 2008
  14. Bert WesargNov 21, 2008
  15. martin f krafftNov 21, 2008
  16. martin f krafftNov 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.