git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7)

From
Lessley Dennington <lessleydennington@gmail.com>
Date
Dec 8, 2021, 22:58 UTC
Message-ID
<3478ff65-b1ce-5b5c-2053-90b927b66779@gmail.com>
In-Reply-To
<xmqqtufiztp9.fsf@gitster.g>
On 12/8/21 1:13 PM, Junio C Hamano wrote:
Show 34 quoted lines
> Lessley Dennington <lessleydennington@gmail.com> writes:
> 
>>> * ld/sparse-diff-blame (2021-12-06) 8 commits
>>>    - blame: enable and test the sparse index
>>>    - diff: enable and test the sparse index
>>>    - diff: replace --staged with --cached in t1092 tests
>>>    - repo-settings: prepare_repo_settings only in git repos
>>>    - test-read-cache: set up repo after git directory
>>>    - commit-graph: return if there is no git directory
>>>    - git: ensure correct git directory setup with -h
>>>    - Merge branch 'vd/sparse-reset' into ld/sparse-diff-blame
>>>    (this branch is used by ds/fetch-pull-with-sparse-index; uses vd/sparse-reset.)
>>>    Teach diff and blame to work well with sparse index.
>>>    Will merge to 'next'?
>>>    source: <pull.1050.v6.git.1638806161.gitgitgadget@gmail.com>
>>
>> This series has been reviewed at different stages by:
>> ...
>> I believe all comments have been addressed (either in the form of a
>> re-roll or a patch or explanation in my reply) and that this branch is
>> ready to merge to 'next'. I have cc'd all reviewers, though, in case there
>> was something I missed.
> 
> I think the patches in this series are in good shape.  The other
> topic this series depends on is already in 'next', so we can mark
> this for 'next', too.
> 
> Note that "explanation in reply" does not count as much as an
> improved version would.  If the code or the log message puzzled a
> reviewer during the review, future readers of the code and "git log"
> will be puzzled the same way.
> 
> Thanks.
> 

Thank you for the feedback, I will take that into account for future series.

Lessley
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “What's cooking in git.git (Dec 2021, #02; Tue, 7)”
  1. Junio C HamanoDec 8, 2021
  2. Eric SunshineDec 8, 2021
  3. Elijah NewrenDec 8, 2021
  4. ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7)Lessley Dennington, Dec 8, 2021
  5. Elijah NewrenDec 8, 2021
  6. Junio C HamanoDec 8, 2021
  7. Lessley DenningtonDec 8, 2021
  8. Junio C HamanoDec 9, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.