git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7)

From
Elijah Newren <newren@gmail.com>
Date
Dec 8, 2021, 20:18 UTC
Message-ID
<CABPp-BHzzrEkr6NaH5ms+xJC4H3_NxRyUJLqVf1Oth-Ln-mddA@mail.gmail.com>
In-Reply-To
<a4968ff2-17c6-faa8-e9be-0c1880e870dd@gmail.com>

On Wed, Dec 8, 2021 at 11:58 AM Lessley Dennington <lessleydennington@gmail.com> wrote:

Show 44 quoted lines
>
> > * ld/sparse-diff-blame (2021-12-06) 8 commits
> >   - blame: enable and test the sparse index
> >   - diff: enable and test the sparse index
> >   - diff: replace --staged with --cached in t1092 tests
> >   - repo-settings: prepare_repo_settings only in git repos
> >   - test-read-cache: set up repo after git directory
> >   - commit-graph: return if there is no git directory
> >   - git: ensure correct git directory setup with -h
> >   - Merge branch 'vd/sparse-reset' into ld/sparse-diff-blame
> >   (this branch is used by ds/fetch-pull-with-sparse-index; uses vd/sparse-reset.)
> >
> >   Teach diff and blame to work well with sparse index.
> >
> >   Will merge to 'next'?
> >   source: <pull.1050.v6.git.1638806161.gitgitgadget@gmail.com>
> >
>
> This series has been reviewed at different stages by:
>
> Junio C Hamano <gitster@pobox.com>
>         - Suggested addition of BUG in prepare_repo_settings.
>         - Suggested --help fix for certain builtins when run outside repos
>           or with special config settings.
>         - Suggested using --cached instead of --staged in diff tests.
> Elijah Newren <newren@gmail.com>
>         - Suggested diff commit message cleanup.
>         - Corrected git commit message typo.
>         - Corrected comment on blame sparse index tests specifying why
>           this builtin does not work on files outside the working
>           directory.
> Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>         - Suggested lower case first letter in prepare_repo_settings BUG
>           message.
> Taylor Blau <me@ttaylor.com>
>         - Suggested diff/blame commit description cleanups
>         - Suggested addition of more diff sparse index test cases
>         - Suggested cleanup of blame sparse index test cases
>
>
> I believe all comments have been addressed (either in the form of a
> re-roll or a patch or explanation in my reply) and that this branch is
> ready to merge to 'next'. I have cc'd all reviewers, though, in case there
> was something I missed.

...and the current version of the series also has my Reviewed-by. I too think this topic is ready for next, as I stated elsewhere[1].

[1] https://lore.kernel.org/git/CABPp-BEd-CLaAJvLpcE=zSinz1up17zh+iUrG--4AXUe765BBA@mail.gmail.com/
Previous: Lessley DenningtonNext: Junio C Hamano
Message 5 of 8 in “What's cooking in git.git (Dec 2021, #02; Tue, 7)”
  1. Junio C HamanoDec 8, 2021
  2. Eric SunshineDec 8, 2021
  3. Elijah NewrenDec 8, 2021
  4. ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7)Lessley Dennington, Dec 8, 2021
  5. Elijah NewrenDec 8, 2021
  6. Junio C HamanoDec 8, 2021
  7. Lessley DenningtonDec 8, 2021
  8. Junio C HamanoDec 9, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.