From: Lessley Dennington Date: Wed, 08 Dec 2021 22:58:44 GMT Subject: Re: ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7) Message-ID: <3478ff65-b1ce-5b5c-2053-90b927b66779@gmail.com> In-Reply-To: On 12/8/21 1:13 PM, Junio C Hamano wrote: > Lessley Dennington writes: > >>> * ld/sparse-diff-blame (2021-12-06) 8 commits >>> - blame: enable and test the sparse index >>> - diff: enable and test the sparse index >>> - diff: replace --staged with --cached in t1092 tests >>> - repo-settings: prepare_repo_settings only in git repos >>> - test-read-cache: set up repo after git directory >>> - commit-graph: return if there is no git directory >>> - git: ensure correct git directory setup with -h >>> - Merge branch 'vd/sparse-reset' into ld/sparse-diff-blame >>> (this branch is used by ds/fetch-pull-with-sparse-index; uses vd/sparse-reset.) >>> Teach diff and blame to work well with sparse index. >>> Will merge to 'next'? >>> source: >> >> This series has been reviewed at different stages by: >> ... >> I believe all comments have been addressed (either in the form of a >> re-roll or a patch or explanation in my reply) and that this branch is >> ready to merge to 'next'. I have cc'd all reviewers, though, in case there >> was something I missed. > > I think the patches in this series are in good shape. The other > topic this series depends on is already in 'next', so we can mark > this for 'next', too. > > Note that "explanation in reply" does not count as much as an > improved version would. If the code or the log message puzzled a > reviewer during the review, future readers of the code and "git log" > will be puzzled the same way. > > Thanks. > Thank you for the feedback, I will take that into account for future series. Lessley