Re: ld/sparse-diff-blame, was What's cooking in git.git (Dec 2021, #02; Tue, 7)

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 8, 2021, 21:13 UTC
Message-ID: <xmqqtufiztp9.fsf@gitster.g>
In-Reply-To: <a4968ff2-17c6-faa8-e9be-0c1880e870dd@gmail.com>

Lessley Dennington <lessleydennington@gmail.com> writes:

Show 20 quoted lines

>> * ld/sparse-diff-blame (2021-12-06) 8 commits
>>   - blame: enable and test the sparse index
>>   - diff: enable and test the sparse index
>>   - diff: replace --staged with --cached in t1092 tests
>>   - repo-settings: prepare_repo_settings only in git repos
>>   - test-read-cache: set up repo after git directory
>>   - commit-graph: return if there is no git directory
>>   - git: ensure correct git directory setup with -h
>>   - Merge branch 'vd/sparse-reset' into ld/sparse-diff-blame
>>   (this branch is used by ds/fetch-pull-with-sparse-index; uses vd/sparse-reset.)
>>   Teach diff and blame to work well with sparse index.
>>   Will merge to 'next'?
>>   source: <pull.1050.v6.git.1638806161.gitgitgadget@gmail.com>
>
> This series has been reviewed at different stages by:
> ...
> I believe all comments have been addressed (either in the form of a
> re-roll or a patch or explanation in my reply) and that this branch is
> ready to merge to 'next'. I have cc'd all reviewers, though, in case there
> was something I missed.

I think the patches in this series are in good shape. The other topic this series depends on is already in 'next', so we can mark this for 'next', too.

Note that "explanation in reply" does not count as much as an improved version would. If the code or the log message puzzled a reviewer during the review, future readers of the code and "git log" will be puzzled the same way.

Thanks.