Re: [PATCH v3 2/3] read-tree -m: make error message for merging 0 trees less smart aleck
On Friday, 12 May 2017, 15:28:53 CEST Junio C Hamano wrote:
Show 18 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
> >> @@ -226,9 +226,10 @@ int cmd_read_tree(int argc, const char **argv, const char *unused_prefix)
> >> setup_work_tree();
> >>
> >> if (opts.merge) {
> >> - if (stage < 2)
> >> - die("just how do you expect me to merge %d trees?", stage-1);
> >> switch (stage - 1) {
> >> + case 0:
> >> + die(_("you must specify at least one tree to merge"));
> >> + break;
> >
> > This part looks good.
>
> Thanks. Modulo _(""); I do not think other messages from read-tree
> are marked for i18n (yet).
> The documentation is already i18n, but not the dying messages. This can take place in a specific patch series.
Thanks. Will reroll.