Re: [PATCH v2 1/3] usability: don't ask questions if no reply is required

From: Konstantin Khomoutov <kostix+git@007spb.ru>
Date: May 11, 2017, 10:28 UTC
Message-ID: <20170511102812.3ed3sqycjmapfj35@tigra>
In-Reply-To: <61C67DC73308BD49B2D4B65072480DBA2BDAB97D@DEERLM99EZ1MSX.ww931.my-it-solutions.net>

On Thu, May 11, 2017 at 10:10:05AM +0000, Kerry, Richard wrote:

[...]

Show 18 quoted lines

> > > @@ -1940,7 +1940,7 @@ static void am_resolve(struct am_state *state)
> > >
> > >     if (unmerged_cache()) {
> > >             printf_ln(_("You still have unmerged paths in your index.\n"
> > > -                   "Did you forget to use 'git add'?"));
> > > +                   "You might want to use 'git add' on them."));
> >
> > This case is *not* an "rhetorical question is the most succinct way to convey
> > the information" situation; I think this rewrite is a definite improvement.
> > "You might want to 'git add' them" may be more succinct, though.
> 
> "You might want to use 'git add' on them." It isn't about what you
> *want* to use, it's what you *need* to use, isn't it?  And I'm not
> happy about "on them".  I'm not sure quite why, but the phrasing seems
> odd.  How about "You might need to use 'git add'.", or "You might need
> to use 'git add' first.", or "'git add' needs to be used to add
> files." ,  or "'git add' needs to be used before any other git command
> may be used.".

Why not just

  You should run `git add` on each file with resolved conflicts to mark
  them as such.

I'm not an English speaker but IMHO this phrasing concentrates on the essense of the problem. It's far from being succint, unfortunately.

I also wonder what to do with "deleted by them" state of certain files which are also "unmerged" but `git add`-ing them would be a wrong thing to do if we want to accept the upstream's decision to delete the file. So maybe something like

  You might run `git rm` on a file to accept "deleted by them" for it.

appended to the original hint would be good.