[PATCH 1/4] usability: don't ask questions if no reply is required
- From
Jean-Noel Avila <jn.avila@free.fr>
- Date
- May 3, 2017, 16:29 UTC
- Message-ID
- <20170503162931.30721-1-jn.avila@free.fr>
As described in the bug report at
https://github.com/git/git-scm.com/issues/999
the user was disconcerted by the question asked by the program not requiring a reply from the user. To improve the general usability of the Git suite, The following rule was applied:
if the sentence
* appears in a non-interactive session
* is printed last before exit
* is a question addressing the user ("you")the sentence is turned into affirmative and proposes the option.
Signed-off-by: Jean-Noel Avila <jn.avila@free.fr> --- help.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/help.c b/help.c index bc6cd19cf..4658a55c6 100644 --- a/help.c +++ b/help.c @@ -411,8 +411,8 @@ const char *help_unknown_cmd(const char *cmd) if (SIMILAR_ENOUGH(best_similarity)) { fprintf_ln(stderr, - Q_("\nDid you mean this?", - "\nDid you mean one of these?", + Q_("\nThe most approaching command is", + "\nThe most approaching commands are", n)); for (i = 0; i < n; i++)
-- 2.12.0