Re: [PATCH 3/3] transport: don't show push status if --quiet is given
On Wed, Aug 5, 2009 at 8:27 PM, Sverre Rabbelier<srabbelier@gmail.com> wrote:
Show 14 quoted lines
> On Wed, Aug 5, 2009 at 13:23, Jeff King<peff@peff.net> wrote:
>> + for (; ref; ref = ref->next) {
>> + switch (ref->status) {
>> + case REF_STATUS_NONE:
>> + case REF_STATUS_UPTODATE:
>> + case REF_STATUS_OK:
>> + break;
>> + default:
>> + return 1;
>> + }
>> + }
>
> Is my C getting sloppy or is this a non-looping loop? AFAICS it either
> return 1's on the first run, or breaks?The "break" in this case breaks out of the switch, not the for.
Avery