Re: [PATCH 3/3] transport: don't show push status if --quiet is given
- From
Jeff King <peff@peff.net>
- Date
- Aug 31, 2009, 19:28 UTC
- Message-ID
- <20090831192834.GC4876@sigill.intra.peff.net>
- In-Reply-To
- <4A9C175E.6020905@hartwork.org>
On Mon, Aug 31, 2009 at 08:33:02PM +0200, Sebastian Pipping wrote:
Show 6 quoted lines
> I run git push in a cron job, too. I want mails in error cases only > so I need git push to print errors but _only_ errors to stderr. That > seems impossible with 1.6.4.* and related to what you're discussing here. > > Does the patch you're building address that case already? has it been > applied to any branch already? I got a bit lost in this thread, sorry.
Junio applied the series, and it is in 'master' right now (and so should be part of the upcoming 1.6.5).
Using "git push -q" will do what you want, but playing with it a bit, I think there is one bit missing from the original series:
-- >8 -- Subject: [PATCH] push: teach --quiet to suppress "Everything up-to-date"
This should have been part of 481c7a6, whose goal was to make "git push -q" silent unless there is an error.
Signed-off-by: Jeff King <peff@peff.net> --- transport.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/transport.c b/transport.c index ce91387..f2bd998 100644 --- a/transport.c +++ b/transport.c @@ -908,7 +908,7 @@ int transport_push(struct transport *transport, update_tracking_ref(transport->remote, ref, verbose); } - if (!ret && !refs_pushed(remote_refs)) + if (!quiet && !ret && !refs_pushed(remote_refs)) fprintf(stderr, "Everything up-to-date\n"); return ret; }
-- 1.6.4.2.372.gf7961.dirty