Re: [PATCH 3/3] transport: don't show push status if --quiet is given

From: Jeff King <peff@peff.net>
Date: Aug 5, 2009, 21:17 UTC
Message-ID: <20090805211700.GA24697@coredump.intra.peff.net>
In-Reply-To: <7vws5ix9dz.fsf@alter.siamese.dyndns.org>

On Wed, Aug 05, 2009 at 02:01:44PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> What I meant was that I'd still want to see the non-verbose part of
> print_push_status(), while suppressing the progress report.  That would
> make mails coming from the cron job much more pleasant to read.
> 
> If you somehow can automatically squelch progress without -q for an
> unattended invocation (e.g. cron jobs), then I wouldn't need to pass -q
> and everything will be good.  But if I have to pass -q in order to squelch
> progress, I do not want that same -q to automatically also mean "no status
> output", which is what your 3/3 is about, if I am reading the patch
> correctly.  That's all.

Hmm. Doesn't that already work? pack-objects checks isatty(2) already before outputting progress, which means it should be suppressed when run via cron (the original poster is seeing it, though, which maybe means some crons allocate a terminal?).

But it sounds like git already does what you want; this extra "-q" would really be more about shutting up the ref status. If you really wanted to control them separately (e.g., because your isatty check is not reliable), then maybe it should be split into "--quiet" and "--no-progress"?

-Peff