Re: Making git push output quieter
- From
Jeff King <peff@peff.net>
- Date
- Aug 5, 2009, 20:19 UTC
- Message-ID
- <20090805201937.GB9004@coredump.intra.peff.net>
- In-Reply-To
- <alpine.LFD.2.00.0908051545300.16073@xanadu.home>
On Wed, Aug 05, 2009 at 03:51:27PM -0400, Nicolas Pitre wrote:
Show 6 quoted lines
> > - progress = isatty(2); > > + progress = isatty(1); > > Doesn't this break progress reporting on a push since stdout is never a > tty in that case? Same issue on a fetch although in that case the > progress level is provided explicitly by the caller.
It also doesn't entirely fix the original poster's problem. There are actually two outputs: the progress report and the push status. I think we actually just want a "--quiet" flag here which is passed along to pack-objects, and which suppresses the push status. Patch series to follow:
1/3: push: add --quiet flag 2/3: transport: pass "quiet" flag to pack-objects 3/3: transport: don't show push status if --quiet is given
-Peff