Re: [PATCH 01/18] streaming: rename `git_istream` into `odb_read_stream`

From: Justin Tobler <jltobler@gmail.com>
Date: Nov 19, 2025, 18:49 UTC
Message-ID: <2nd7qcj7jrrwc4fyhfsovs3ptrwmrdxxcap4sqadujtwwua5ha@bpbjlbnbcpiw>
In-Reply-To: <20251119-b4-pks-odb-read-stream-v1-1-adacf03c2ccf@pks.im>

On 25/11/19 08:47AM, Patrick Steinhardt wrote:

> In the following patches we are about to make the `git_istream` more
> generic so that it becomes fully controlled by the specific object
> source that wants to create it. As part of these refactorings we'll
> fully move the structure into the object database subsystem.

Ok, so looking at the current implementation of `git_istream`, it does appear to be already defined in a somewhat generic manner as it supports reading loose/packed objects. What sources are supported are all centrally defined in "streaming.c" though. It sounds like we eventually want each source to fully control this interface without having to go through "streaming.c" to setup each source stream type which makes sense.

Show 16 quoted lines

> Prepare for this change by renaming the structure from `git_istream`
> to `odb_read_stream`. This mirrors the `odb_write_stream` structure that
> we already have.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> diff --git a/streaming.h b/streaming.h
> index bd27f59e57..acf4c84338 100644
> --- a/streaming.h
> +++ b/streaming.h
> @@ -7,14 +7,14 @@
>  #include "object.h"
>  
>  /* opaque */
> -struct git_istream;
> +struct odb_read_stream;

The name change here makes sense. While we are here, it might be nice to leave a comment annotating it's purpose in a bit more detail.

-Justin