Re: [PATCH/RFC 3/4] git-mw: Adding git-mw.perl script

From: Benoit Person <benoit.person@ensimag.fr>
Date: Jun 24, 2013, 17:05 UTC
Message-ID: <2b5734ad750f9ec566215f353b6bb0b5@ensibm.imag.fr>
In-Reply-To: <vpqy59zsb0u.fsf@anie.imag.fr>

Le 2013-06-24 18:56, Matthieu Moy a écrit :

Show 24 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>> benoit.person@ensimag.fr writes:
>>>
>>>> diff --git a/contrib/mw-to-git/git-mw.perl 
>>>> b/contrib/mw-to-git/git-mw.perl
>>>> new file mode 100644
>>>> index 0000000..a2f0aa1
>>>> --- /dev/null
>>>> +++ b/contrib/mw-to-git/git-mw.perl
>>>
>>> *.perl scripts are usually executable in Git's tree (although it's
>>> usually better to run the non-*.perl version).
>>
>> Good eyes.  But if we encourage people to run non-*.perl version,
>> perhaps we should drop the executable bit from the source, no?
>
> But by default, I'd say consistency is most important so if other 
> *.perl
> are executable, we should do the same (otherwise my "ls" shows 
> different
> colors and it's ugly ;-) ).

So it's really a *nice* catch then :) .

> But it may make sense to change the convention, i.e. run a "chmod -x
> *.perl" in Git's tree (in any case, people can still run "perl
> foo.perl").

For what I've seen so far of git.git, the best way would be to make it executable in this patch serie and send another patch applying that 'chmod -x'-thingy ?