Re: [PATCH/RFC 3/4] git-mw: Adding git-mw.perl script

From: Jeff King <peff@peff.net>
Date: Jun 24, 2013, 17:00 UTC
Message-ID: <20130624170056.GA24251@sigill.intra.peff.net>
In-Reply-To: <vpqy59zsb0u.fsf@anie.imag.fr>

On Mon, Jun 24, 2013 at 06:56:17PM +0200, Matthieu Moy wrote:

Show 10 quoted lines

> > Good eyes.  But if we encourage people to run non-*.perl version,
> > perhaps we should drop the executable bit from the source, no?
> 
> But by default, I'd say consistency is most important so if other *.perl
> are executable, we should do the same (otherwise my "ls" shows different
> colors and it's ugly ;-) ).
> 
> But it may make sense to change the convention, i.e. run a "chmod -x
> *.perl" in Git's tree (in any case, people can still run "perl
> foo.perl").

You'd probably want to also change the shell scripts, too, which are marked executable in the repo (but the source-able shell "libraries" are not).

I don't remember the details, but I think there may be some magic with the --valgrind test option that depends on the executable bit to distinguish those two.

-Peff