From: Benoit Person Date: Mon, 24 Jun 2013 17:05:29 GMT Subject: Re: [PATCH/RFC 3/4] git-mw: Adding git-mw.perl script Message-ID: <2b5734ad750f9ec566215f353b6bb0b5@ensibm.imag.fr> In-Reply-To: Le 2013-06-24 18:56, Matthieu Moy a écrit : > Junio C Hamano writes: > >> Matthieu Moy writes: >> >>> benoit.person@ensimag.fr writes: >>> >>>> diff --git a/contrib/mw-to-git/git-mw.perl >>>> b/contrib/mw-to-git/git-mw.perl >>>> new file mode 100644 >>>> index 0000000..a2f0aa1 >>>> --- /dev/null >>>> +++ b/contrib/mw-to-git/git-mw.perl >>> >>> *.perl scripts are usually executable in Git's tree (although it's >>> usually better to run the non-*.perl version). >> >> Good eyes. But if we encourage people to run non-*.perl version, >> perhaps we should drop the executable bit from the source, no? > > But by default, I'd say consistency is most important so if other > *.perl > are executable, we should do the same (otherwise my "ls" shows > different > colors and it's ugly ;-) ). So it's really a *nice* catch then :) . > But it may make sense to change the convention, i.e. run a "chmod -x > *.perl" in Git's tree (in any case, people can still run "perl > foo.perl"). For what I've seen so far of git.git, the best way would be to make it executable in this patch serie and send another patch applying that 'chmod -x'-thingy ?