Re: [PATCH/RFC 3/4] git-mw: Adding git-mw.perl script

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 24, 2013, 16:56 UTC
Message-ID: <vpqy59zsb0u.fsf@anie.imag.fr>
In-Reply-To: <7vfvw7bh0u.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> benoit.person@ensimag.fr writes:
>>
>>> diff --git a/contrib/mw-to-git/git-mw.perl b/contrib/mw-to-git/git-mw.perl
>>> new file mode 100644
>>> index 0000000..a2f0aa1
>>> --- /dev/null
>>> +++ b/contrib/mw-to-git/git-mw.perl
>>
>> *.perl scripts are usually executable in Git's tree (although it's
>> usually better to run the non-*.perl version).
>
> Good eyes.  But if we encourage people to run non-*.perl version,
> perhaps we should drop the executable bit from the source, no?

But by default, I'd say consistency is most important so if other *.perl are executable, we should do the same (otherwise my "ls" shows different colors and it's ugly ;-) ).

But it may make sense to change the convention, i.e. run a "chmod -x *.perl" in Git's tree (in any case, people can still run "perl foo.perl").

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/