Re: [PATCH/RFC v2 1/4] Add "core.eolStyle" variable to control end-of-line conversion
On 9. mai 2010, at 19.45, Junio C Hamano wrote:
Show 12 quoted lines
> Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com> writes:
>
>> My user interface would have been:
>>
>> - an attribute "eolconv" that enables or disables line ending conversion
>> - a config variable "core.eolconv" that sets "eolconv" for all files where it is unset
>> - a config variable "core.localeol" that decides whether LF or CRLF is preferred
>
> I am puzzled about this second item; what is its type and what is its
> purpose? If it is to allow project-wide default to be specified, then
> isn't having "* eolconv=true" in .gitattributes a much better option and
> is already supported by the first item?
Yes, but if the repository maintainers don't want to make that change (for whatever reason), it might be nice for the user to be able to enable normalization locally. It would be a boolean, and setting it would mean the equivalent of "crlf=auto" on all files where "crlf" is not explicitly set.
--
Eyvind
Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com>